Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "fragLoadingRetryDelay" is ignored when the ts files are non existent (404 on all ts files) #4312

Closed
5 tasks done
sdiemer opened this issue Sep 8, 2021 · 4 comments · Fixed by #4858
Closed
5 tasks done
Labels
Bug Confirmed Bug report confirmed or reproduced.
Milestone

Comments

@sdiemer
Copy link

sdiemer commented Sep 8, 2021

What version of Hls.js are you using?

v1.0.10

What browser (including version) are you using?

Firefox 92.0 x64

What OS (including version) are you using?

Debian 10

Test stream

https://mirismanager.ubicast.eu/media/storage/ts-404.m3u8

Configuration

{}

Additional player setup steps

No response

Checklist

Steps to reproduce

  1. Open the player with the test stream. To reveal the problem, the test stream is a playlist containing only ts fragments leading to 404 errors.

Expected behaviour

The player should wait for the delay configured in fragLoadingRetryDelay between two attempts.

What actually happened?

The player retries without any delay between requests.

Some of our users reported the same problem with Chrome.
I don't think that the problem is OS dependant.

The issue is possibly related to a similar old issue on m3u8 files:
#1121

Console output

41.682 | Media element detached
41.709 | Loading https://mirismanager.ubicast.eu/media/storage/ts-404.m3u8
41.72 | Loading manifest and attaching video element...
41.756 | 1 quality levels found
41.758 | Manifest successfully loaded
41.779 | Media element attached

Errors:
41.877 | Error while loading fragment https://mirismanager.ubicast.eu/media/storage/404ts-10660.ts
41.981 | Error while loading fragment https://mirismanager.ubicast.eu/media/storage/404ts-10660.ts
42.091 | Error while loading fragment https://mirismanager.ubicast.eu/media/storage/404ts-10660.ts
...

Chrome media internals output

No response

@sdiemer sdiemer added Bug Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Sep 8, 2021
@dylanjha
Copy link
Contributor

@sdiemer interesting. Thanks for opening. I notice this is a live playlist -- do you see the same behavior for VOD?

@sdiemer
Copy link
Author

sdiemer commented Sep 22, 2021

@dylanjha Hello, I have written a VOD playlist with all ts leading the 404:
https://mirismanager.ubicast.eu/media/storage/ts-404-vod.m3u8
The issue isn't affecting VOD playlist, it only happens on live playlists.

@robwalch robwalch added Confirmed Bug report confirmed or reproduced. and removed Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Aug 17, 2022
robwalch added a commit that referenced this issue Aug 19, 2022
Also stops playlist and key loading when stopLoad is called (Related to #4312)
robwalch added a commit that referenced this issue Aug 19, 2022
Also stops playlist and key loading when stopLoad is called (Related to #4312)
@robwalch
Copy link
Collaborator

The immediate re-request on live stream start was in place because of an assumption that the error was a down-switch and/or that if we did not immediately reattempt starting, we could loose sync between audio and video and the live stream would stall with mismatched audio/video buffered ranges. The majority of such edge cases have been fixed since roughly v1.1 with resetLiveStartWhenNotLoaded now renamed resetStartWhenNotLoaded with #4858.

@robwalch robwalch added the Verify Fixed An unreleased bug fix has been merged and should be verified before closing. label Aug 22, 2022
robwalch added a commit that referenced this issue Aug 29, 2022
Also stops playlist and key loading when stopLoad is called (Related to #4312)
@robwalch robwalch added this to the 1.2.2 milestone Aug 29, 2022
robwalch added a commit that referenced this issue Aug 29, 2022
* Fix frag error handling with live streams (Fixes #4312)
Also stops playlist and key loading when stopLoad is called (Related to #4312)

* Fix level fail over when alt-audio segments error
@sdiemer
Copy link
Author

sdiemer commented Aug 30, 2022

Hello, thank you for the fix :)

@robwalch robwalch removed the Verify Fixed An unreleased bug fix has been merged and should be verified before closing. label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed Bug report confirmed or reproduced.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants