-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENDED event is not raised on live stream, even though #EXT-X-ENDLIST arrived and no more manifests #5777
Comments
Can the issue be reproduced with the dev and or latest version of HLS.js standalone without kaltura player? |
The issue is that your live playlist adds the endlist without adding a new segment. HLS.js only recognizes the end list when it is added with the last segment, not after: Second to last update:
Last update adds ENDLIST only. As it doesn't contain a new segment, end list is not tracked:
HLS.js logs no changes before stall error
|
It's perfectly valid to update the playlist with an end list tag so I came up with a fix. Please take a look at #5778 and let me know if you or anyone else at Kaltura can review the PR. This fix will go in v1.5.0. If you need a patch please open a PR against the "patch/v1.4.x" branch. |
* Handle #EXT-X-ENDLIST appended to live playlist without new segment * Update segment in fragment tracker when the last fragment gets `endList` added * Do not modify old fragment reference Fixes #5777 --------- Co-authored-by: Rob Walch <robwalch@users.noreply.github.com> Co-authored-by: Sergey Marchenko <sergey.dnepro@gmail.com>
What version of Hls.js are you using?
1.3.5
What browser (including version) are you using?
Chrome Version 115.0.5790.170 (Official Build) (x86_64)
What OS (including version) are you using?
MacOs Ventura 13.2.1
Test stream
https://codepen.io/Semarche/full/NWeKjYE
Configuration
Additional player setup steps
No response
Checklist
Steps to reproduce
Notice that the emitted events are monitored below.
Expected behaviour
ENDED event should be emitted.
It worked as expected up until HLSJS version 1.3.0, from that version the event is not being raised.
What actually happened?
Last event emitted is BUFFERING
Console output
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: