-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate SVTA Common Media Library's ID3 utilities #6168
Comments
Hi @fyoungqualabs, Thanks for creating this issue. In this issue and upcoming PRs for @svta/common-media-library ID3 parser please provide specific examples (or links to them). I found streaming-video-technology-alliance/common-media-library#16 with very little information about what this part of the library normalized between hls.js, shaka-player, and dash.js.
Which parts?
Which bugs? |
CML's ID3 utilities are largely based on hls.js's. All of the functionality that currently exists in hls.js exists in CML. There are some other features that will be pulled in from Shaka, especially around tags used in audio only streams. |
#6260 has been merged and is set to release in v1.6.0. |
Is your feature request related to a problem? Please describe.
The ID3 utility functions in CML are based in part on the ones in hls.js. Now that the ID3 functionality has been consolidated from the player libraries, the players should be refactored to use CML's version.
Describe the solution you'd like
Replace every id3 function with those that are on common media library.
Additional context
Looking at open source players like hls.js, dash.js and shaka-player there are common pieces of functionality that have been implemented independently, and sometimes copy and pasted, across the libraries. This is particularly true when looking at standards based features, like ID3 parsing, 608 parsing and CMCD. Since the functionality is shared in spirit but not implementation, they can fall out of sync where certain bugs are fixed in one player but not the others. The goal of common media library is to create a single place where these utilities can be maintained and distributed.
The text was updated successfully, but these errors were encountered: