Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate SVTA Common Media Library's ID3 utilities #6168

Closed
felipeYoungi opened this issue Feb 1, 2024 · 3 comments · Fixed by #6260
Closed

Integrate SVTA Common Media Library's ID3 utilities #6168

felipeYoungi opened this issue Feb 1, 2024 · 3 comments · Fixed by #6260
Milestone

Comments

@felipeYoungi
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The ID3 utility functions in CML are based in part on the ones in hls.js. Now that the ID3 functionality has been consolidated from the player libraries, the players should be refactored to use CML's version.

Describe the solution you'd like

Replace every id3 function with those that are on common media library.

Additional context

Looking at open source players like hls.js, dash.js and shaka-player there are common pieces of functionality that have been implemented independently, and sometimes copy and pasted, across the libraries. This is particularly true when looking at standards based features, like ID3 parsing, 608 parsing and CMCD. Since the functionality is shared in spirit but not implementation, they can fall out of sync where certain bugs are fixed in one player but not the others. The goal of common media library is to create a single place where these utilities can be maintained and distributed.

@felipeYoungi felipeYoungi added Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Feb 1, 2024
@robwalch robwalch added Enhancement and removed Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Feb 1, 2024
@robwalch
Copy link
Collaborator

robwalch commented Feb 1, 2024

Hi @fyoungqualabs,

Thanks for creating this issue. In this issue and upcoming PRs for @svta/common-media-library ID3 parser please provide specific examples (or links to them). I found streaming-video-technology-alliance/common-media-library#16 with very little information about what this part of the library normalized between hls.js, shaka-player, and dash.js.

The ID3 utility functions in CML are based in part on the ones in hls.js.

Which parts?

they can fall out of sync where certain bugs are fixed in one player but not the others

Which bugs?

@littlespex
Copy link
Collaborator

littlespex commented Feb 1, 2024

CML's ID3 utilities are largely based on hls.js's. All of the functionality that currently exists in hls.js exists in CML. There are some other features that will be pulled in from Shaka, especially around tags used in audio only streams.

@robwalch robwalch linked a pull request Apr 18, 2024 that will close this issue
2 tasks
@robwalch robwalch added this to the 1.6.0 milestone Apr 18, 2024
@robwalch robwalch added the Verify Fixed An unreleased bug fix has been merged and should be verified before closing. label Apr 18, 2024
@robwalch
Copy link
Collaborator

#6260 has been merged and is set to release in v1.6.0.

@robwalch robwalch removed the Verify Fixed An unreleased bug fix has been merged and should be verified before closing. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants