-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/switch id3 functions with cml id3 functions #6260
Merged
robwalch
merged 17 commits into
video-dev:master
from
qualabs:refactor/switch-id3-functions-with-cml-id3-functions
Apr 4, 2024
Merged
Refactor/switch id3 functions with cml id3 functions #6260
robwalch
merged 17 commits into
video-dev:master
from
qualabs:refactor/switch-id3-functions-with-cml-id3-functions
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: coatesjuan <juanco@qualabs.com>
This reverts commit 57203a7.
Signed-off-by: Felipe Young <felipey@qualabs.com>
Signed-off-by: Felipe Young <felipey@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: Felipe Young <felipey@qualabs.com>
robwalch
previously approved these changes
Mar 4, 2024
robwalch
reviewed
Mar 4, 2024
robwalch
reviewed
Mar 4, 2024
robwalch
dismissed
their stale review
March 4, 2024 22:27
Would like to see de-duplication of utils and payload size before and after.
Signed-off-by: Fernando Cuadro <fernandoc@qualabs.com>
Signed-off-by: Fernando Cuadro <fernandoc@qualabs.com>
robwalch
requested changes
Mar 13, 2024
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
robwalch
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
What improvements to ID3 Parsing will this change include?
Why is this Pull Request needed?
The id3 utilities have been manually implemented in multiple player libraries. When bugs need to be fixed, or features added, then need to be done across all of these projects. The common media library provides a single place for these utilities to live and be maintained.
Also hls.js doesn't parse id3 APIC data and with this change it is going to be able to handle that data.
What assets have these changes been tested against?
We tested this changes using 2 assets:
https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_16x9/bipbop_16x9_variant.m3u8
https://test-streams.mux.dev/dai-discontinuity-deltatre/manifest.m3u8
https://stream-cdn-1.open.fm/OFM18/ngrp:standard/playlist.m3u8(APIC between songs).
What history and roadmap for the CML can you share(based on which player code and tested for which application use cases)?
We currently use Github milestones (same as hls.js), in combination with the project board. We only have a few features officially planned, so the roadmap isn't very big:
https://github.com/streaming-video-technology-alliance/common-media-library/milestones
Checklist