-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit keySystemLicenseRequestFailed
twice if we block the license
#6701
Comments
License requests are retried based on the configured Provide a
hls.js/src/controller/eme-controller.ts Lines 1160 to 1181 in deef247
|
keySystemLicenseRequestFailed
twice if we block the licnesekeySystemLicenseRequestFailed
twice if we block the license
keySystemLicenseRequestFailed
twice if we block the license
No the issue is not about the retry config. I mean, we emit twice error with 1 reach the max retry count and reject the error
2 `renewLicense` catches the error and emits the error data once
3 `licenseStatus` emits the same error and rejects it
4 `keySessionContextPromise` catch the `licenseStatus` rejected error and emits twice |
keySystemLicenseRequestFailed
twice if we block the license
#6703 A PR helps to describe the issue. |
What version of Hls.js are you using?
the master
What browser (including version) are you using?
The recent Chrome 130.x
What OS (including version) are you using?
Mac OS Sonoma
Test stream
https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine-hls/hls.m3u8
Configuration
Additional player setup steps
Please block the license url
https://cwip-shaka-proxy.appspot.com/no_auth
via Chrome DevtoolChecklist
Steps to reproduce
https://codepen.io/Jack_Pu/pen/ZEddVPQ
https://cwip-shaka-proxy.appspot.com/no_auth
via Chrome DevtoolExpected behaviour
trigger
keySystemLicenseRequestFailed
only one timeWhat actually happened?
trigger
keySystemLicenseRequestFailed
twiceConsole output
More information
I located here https://github.com/video-dev/hls.js/blob/master/src/controller/eme-controller.ts#L771-L772
We use
this.handleError(error);
to send the error event. But then we uselicenseStatus
to emit the error. So it will trigger the error one more time.https://github.com/video-dev/hls.js/blob/master/src/controller/eme-controller.ts#L809
https://github.com/video-dev/hls.js/blob/master/src/controller/eme-controller.ts#L459
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: