Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LL-HLS RENDITION-REPORT playlist variant switching #3125

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Oct 17, 2020

This PR will...

  • Use RENDITION-REPORT details to make blocking reload requests when switching level/audio/subtitle playlists
  • Add type and url to "hlsSubtitleTrackSwitch" events switching to a track
    • Subtitle disabling switches to index -1 continue to only contain { id }

Why is this Pull Request needed?

These changes allow us to make blocking playlist requests for variants that should be (close to) the latest already available on the origin and edge.

Are there any points in the code the reviewer needs to double check?

These changes use the previous playlist report's LAST-MSN and LAST-PART attributes for the variant being switched to as parameters in the request for that playlist.

Improvements to low-latency switching like playlist/segment prefetching or variant latency/under-buffer estimates using these reports are not included in this change-set.

Checklist

  • changes have been done against the feature/v1.0.0 branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.0.0 milestone Oct 17, 2020
@robwalch robwalch force-pushed the feature/ll-hls-rendition-report-switching branch from 40fb6a5 to 7b23412 Compare October 18, 2020 15:07
Copy link
Collaborator

@itsjamie itsjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@robwalch robwalch merged commit 12d5548 into feature/v1.0.0 Oct 19, 2020
@robwalch robwalch deleted the feature/ll-hls-rendition-report-switching branch October 19, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants