Fix issue that causes DISCONTINUITY values to be reassigned incorrectly #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`level.fragmentHint` should only be set on playlists with parts, as it can misrepresent the ending discontinuity sequence number on playlists without them
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix an issue that causes DISCONTINUITY values to be reassigned incorrectly.
Why is this Pull Request needed?
level.fragmentHintshould only be set on playlists with LL-HLS parts, and should not be used to detect "discontinuity sliding from playlist" inmergeDetailson live playlist update, as they could have a different discontinuity sequence number than the matching fragment in the next update. This results in accOffsetthat adjusts segments discontinuity sequence numbers incorrectly. We don't want that because then audio and video playlist alignment shifts things around, and it's a bad time for everyone.Checklist