Bugfix: segment loading order with gaps #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncorrect or is greater than media segment duration #4828
robwalch
force-pushed
the
bugfix/segment-loading-order
branch
from
b31b0e4 to
eae75e1
Compare
robwalch
added a commit
that referenced
this pull request
Sep 8, 2022
3 tasks
robwalch
added a commit
that referenced
this pull request
Sep 8, 2022
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Stop using
nextLoadPositionto find fragments as soon as the first media segment is appended. Use media timecode when fragmented MP4 mux input has audio and video.Why is this Pull Request needed?
Prevents stream controllers from skipping segments and appending media at the wrong time when the first playlist segment duration is longer than the parsed media segment. This could happen when an audio encoder drops out leaving a large gap which is then added to the segment duration without splitting it into a new segment or marking it with a GAP tag.
Resolves issues:
#4828
Checklist