Fix handling of negative composition timestamps #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjamie
reviewed
Sep 8, 2022
src/remux/mp4-generator.ts
Outdated
| @@ -1084,7 +1084,7 @@ class MP4 { | |||
| offset += 8 + arraylen; | |||
| array.set( | |||
| [ | |||
| 0x00, // version 0 | |||
| 0x01, // version 1 to signal signed ctts | |||
There was a problem hiding this comment.
As we discussed in Slack, given we are producing a track for audio and a separate track for video, according to CMAF we should only use v1 trun for the video track to allow reordering I/P/B frames.
The offset we record should make the composition time match the first media sample decode time.
…"PTS < DTS" warnings) Fixes #4878
…r to reload. (prevents loop loading on https://playertest.longtailvideo.com/adaptive/captions/playlist.m3u8 which now presents gaps in Safari)
robwalch
force-pushed
the
bugfix/signed-composition-timestamps
branch
from
ca86969 to
50ceebf
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix handling of negative composition timestamps in MPEG-2 TS remuxing.
Remove loading of "partial" segments. If MSE doesn't append the full segment duration this is likely an issue with the media. This avoids loop loading. Reloading of ejected media is still covered by the fragment tracker.
Why is this Pull Request needed?
This change eliminates the "PTS < DTS" warnings and workarounds. The mp4 "trun" box version is set to 1 to signal that composition timestamps are signed.
Resolves issues:
Fixes #4878
Checklist