fix npm publishes not happening #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because npm/cli#2740 broke the npm `--json` flag
tjenkinson
changed the title
robwalch
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Make
check-already-publishedhit api directly.Why is this Pull Request needed?
Because npm/cli#2740 broke the npm
--jsonflag meaning the json output is mixed with standard text output (😱). Hopefully the api itself will be stable. With this current bug no npm publishes are happening given the check says they are already there.We should skip the publish stage if the package is already published so that the rest of the pipeline can run and go green if the pipeline needs to be retried after a publish already succeeded.
Alternative to #4890