Remove SIDX playlist MAP patching #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
bugfix/remove-map-sidx-patch
branch
from
e223a20
to
2a1f0b5
Compare
robwalch
added a commit
that referenced
this pull request
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Remove code that makes additional byte-range requests when media playlists are missing a MAP tag and have file extensions that suggest MP4 container format.
Why is this Pull Request needed?
Segment file extensions should not impact player behavior. EXT-X-MAP tags are required by fMP4 segments in HLS media playlists. The code being removed is the root-cause for #4274.
The code being removed was added in #1442. It is not needed for the stream in the description. This suggests it was added to support an early version of shaka-packager or DASH streams ported to HLS without the required MAP tags.
Are there any points in the code the reviewer needs to double check?
Is anyone depending on the code being removed?
Are there such HLS streams and are they supported in other HLS clients?
I am assuming no to both and if wrong then would prefer to see an fmp4 specific demuxer error which included sidx data so that this fix could be applied as a fallback (slower but would not result in issues like #4274).
Resolves issues:
Resolves #4274
Checklist