Skip large video start gaps using GAP flag #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
commented
Sep 12, 2023
robwalch
force-pushed
the
bugfix/skip-large-video-start-gap
branch
from
373fa49 to
607f527
Compare
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Skip large video start gaps using the Fragment gap flag.
Why is this Pull Request needed?
The gap-controller only skips start gaps less than two seconds in length. HLS.js can jump larger gaps and will for any fragment marked with a gap flag. There are already cases where this flag is added when segments are found to be a) completely missing all video samples or b) dropping initial samples because of not starting with a key-frame. This change adds the case where nothing is dropped from the segment, but it still starts more than 2 seconds after the start of the audio track.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #4975, #4066
Checklist