Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for aligning live alt audio and subtitle playlists on msn without PDT #5818

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

robwalch
Copy link
Collaborator

This PR will...

Keep a reference to the last loaded level or track playlist object, and use it when aligning live playlists without PDT.

Why is this Pull Request needed?

Track group id changes replace track list, making it impossible to access the level or details object used prior to the switch using level[index].

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #5802

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…nce track group changes replace track list

Resolves #5802
@robwalch robwalch added this to the 1.5.0 milestone Sep 12, 2023
@robwalch robwalch merged commit e104067 into master Sep 13, 2023
@robwalch robwalch deleted the bugfix/align-on-switched-playlist-sn branch September 13, 2023 18:15
@rajeshdish
Copy link

Seeing regression With this MR
Everytime we seek backwards we have to provide new URL to player, we call stopLoad> loadSource(with new URL)
during this time we are seeing this error and loadSource is not working (in playback only one segment keep repeating itself with freezes)

All fragments start & end time is in negative values

Screenshot 2023-09-19 at 6 52 51 AM

@rajeshdish
Copy link

rajeshdish commented Sep 19, 2023

this delta is going negative values (eg: -3232 | -2332)
with this changes playback started to work.

Screenshot 2023-09-19 at 8 53 27 AM

OR

Screenshot 2023-09-19 at 9 21 06 AM

@rajeshdish
Copy link

@robwalch ^^

@robwalch
Copy link
Collaborator Author

robwalch commented Sep 19, 2023

@rajeshdish,

Please fill out the Bug Report Template as part of your issue, making sure to include:

  • Test stream/page (if possible)
  • Steps to reproduce
  • Expected behavior
  • Actual behavior

If the issue is related to your stream, and you cannot share the stream, please include all the information we would need to reproduce the issue. This includes how to generate a stream that reproduces the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If It use multiple audio groups in fmp4 format, startPTS will be incorrectly recognized.
2 participants