Align playlists streaming start position with mismatched end-list tags #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…btitle streaming controllers Fixes #6126
robwalch
deleted the
bugfix/align-playlists-start-with-vod-live-mismatch
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Use main playlist details to determine start position of audio and subtitle streaming controllers
Why is this Pull Request needed?
Startup worked (corrected itself) in 1.4 but regressed in 1.5 to only load live edge on live media playlists (audio) and first segment in vod media playlists (main) which results in playback not starting (no combined buffer) until a seek.
Are there any points in the code the reviewer needs to double check?
How does this impact live start? So far looks like a more aligned start time results in fast start times when initial live playlist are not perfectly aligned. Not sure if there are some edge cases where the main start time presents a problem for audio or sub playlists abnormal starts or alignment.
Resolves issues:
Fixes #6126
Checklist