Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio/subtitles stream controllers restarting on switch after stopped #6227

Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Feb 20, 2024

This PR will...

  • Fix audio/subtitles stream controllers restarting on switch after stopped
  • Update audio/subtitles stream controller access specifiers

Why is this Pull Request needed?

Switching tracks should not restart loading of segments after hls.stopLoad() has been called.
Access specifiers should limit access of class methods meant for internal use only.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…pped

Update stream controller access specifiers
@robwalch robwalch added this to the 1.6.0 milestone Feb 20, 2024
@robwalch robwalch merged commit 03ca1c7 into master Feb 21, 2024
16 checks passed
@robwalch robwalch deleted the feature/stream-controller-access-specifiers-and-cleanup branch February 21, 2024 19:02
@robwalch robwalch mentioned this pull request Feb 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant