Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup buffer-helper functions and remove nested try-catch statements #6228

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

robwalch
Copy link
Collaborator

This PR will...

Cleanup buffer-helper functions and remove nesting try-catch statements

Why is this Pull Request needed?

  • Fixes case where getBuffered can return undefined (media.buffered if not defined should fallthough to empty TimeRange)
  • isBuffered and bufferInfo no longer need try-catch blocks because they don't throw and neither do their sub-routines

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Feb 20, 2024
@robwalch robwalch merged commit 40b382b into master Feb 21, 2024
16 checks passed
@robwalch robwalch deleted the task/buffer-helper-cleanup branch February 21, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant