Fix extraction of NALu overflowing PES packet #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
approved these changes
Apr 11, 2024
robwalch
added a commit
that referenced
this pull request
Jun 12, 2024
Revert NALu overflow handling change introduced in #6268 that results in a decode error at 30s w/ https://playertest.longtailvideo.com/adaptive/elephants_dream_v4/media/b2962000-video.m3u8 `PIPELINE_ERROR_DECODE: Error Domain=NSOSStatusErrorDomain Code=-12909 "(null)" (-12909): VTDecompressionOutputCallback`
3 tasks
robwalch
added a commit
that referenced
this pull request
Jun 12, 2024
Revert NALu overflow handling change introduced in #6268 that results in a decode error at 30s w/ https://playertest.longtailvideo.com/adaptive/elephants_dream_v4/media/b2962000-video.m3u8 `PIPELINE_ERROR_DECODE: Error Domain=NSOSStatusErrorDomain Code=-12909 "(null)" (-12909): VTDecompressionOutputCallback`
This was referenced Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this Pull Request needed?
It prevents error "Malformed SEI payload. X is too small, only Y bytes left to parse" in case when SEI overflows PES. It also adds new test stream, HEVC in MPEG-TS, with variety of such NAL units of different types.
Test stream: mpegTsBitmovinHevc (see
test-streams.js)Checklist
PS
In spite of the error video track can be played. Therefore if this PR is approved, the changes can be merged right before 1.6.0 release in order to avoid inconvenience with
patchbranch.