Bugfix: Handle duplicate audio codec in CODECS #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…io codec strings are present in the Multivariant Playlist variant CODECS attribute with muxed content Fixes #6337
robwalch
deleted the
bugfix/sourcebuffer-creation-multiple-audio-codecs-in-manifest-with-ts
branch
robwalch
added a commit
that referenced
this pull request
Apr 11, 2024
* patch/v1.5.x: Bugfix: Patch for light player exception with audio groups (#6342) Do not use "levelCodec" to instantiate SourceBuffer when multiple audio codec strings are present in the Multivariant Playlist variant CODECS attribute with muxed content (#6341) Bugfix: preferManagedMediaSource:false when MSE is not present (#6338) Determine canSkip based on age of last playlist request (#6300) API.md update removeLevel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Avoid using "levelCodec" to instantiate the audio SourceBuffer when multiple audio codec strings are present in the Multivariant Playlist CODECS attribute for muxed content (TS segment without alt-audio).
Why is this Pull Request needed?
SourceBuffer creation fails with invalid mime-time.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #6337
Checklist