Fix HE-AACv1 and v2 in fMP4 on iOS #6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe is not supported Fixes #6470
5 tasks
robwalch
added a commit
that referenced
this pull request
Jun 1, 2024
* patch/v1.5.x: Don't append over first fragment when next fragment aligns with playlist within 1/200s tolerance (#6471) Fix exception reading metadata.channelCount with HE-AAC when changeType is not supported (#6472) Fix TSDemuxer parsing error handling in sync path (#6469) when `this.stats` is called, add optional chaining or check for existence (#6459)
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix exception reading metadata.channelCount with HE-AAC when changeType is not supported.
Why is this Pull Request needed?
audio.metadatais undefined after parsing mp4 init segments.Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #6470
Checklist