Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reduce max buffer length #6530

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jul 1, 2024

This PR will...

Reduce max buffer length in response to buffer full errors using the duration of the fragment that caused the error .

  • Max buffer length is reduced by three fragment durations or half (whichever result is greater)
  • The minimum value for max buffer length is constrained between maxBufferLength and fragment duration

Why is this Pull Request needed?

reduceMaxBufferLength was a no-op when its input was greater than half maxMaxBufferLength.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #6529

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.12 milestone Jul 1, 2024
@robwalch robwalch merged commit 1a3c235 into master Jul 1, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/reduce-max-buffer-length branch July 1, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated QuotaExceededError
1 participant