Fix parsing of multiple video codecs when converting from AVC1 to AVCOTI #6533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
requested changes
Jul 2, 2024
jhonatangcavalcanti
force-pushed
the
feature/fix-manifest-incompatible-codecs-error
branch
from
dda848d
to
274d91e
Compare
|
Hello, @robwalch. Thanks for the fast review. I made the changes you asked for, can you check again? |
robwalch
approved these changes
Jul 3, 2024
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix the parse of multiple value codecs (CODECS="avc1.64001E,avc1.64001f,mp4a.40.2") on
convertAVC1ToAVCOTIfunction.Before this MR, the codec value was converted from "avc1.64001E,avc1.64001f" to "avc1.fa01fa01" leading to the "no level with compatible codecs found in manifest" error.
Now, it is keeping the "avc1.64001E,avc1.64001f" value.
Why is this Pull Request needed?
It fixes media with multiple video codecs broken on
1.5.xhls.js versions.Ex.:
#EXT-X-STREAM-INF:BANDWIDTH=1199000,RESOLUTION=854x480,CODECS="avc1.64001E,avc1.64001f,mp4a.40.2",AUDIO="audio",SUBTITLES="subs"Are there any points in the code the reviewer needs to double check?
Resolves issues:
Related to #5378
Checklist