Trigger ATTACH_MEDIA_ERROR when calling attachMedia with falsey media argument
#6556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new error detail for attachMedia
trigger error if media is null
unit test for null condition in attachMedia and some spelling mistake corrections in previous tests
update ErrorDetails
robwalch
requested changes
Jul 16, 2024
omitting `reason` property, since it is the same message
robwalch
approved these changes
Jul 16, 2024
robwalch
requested changes
Jul 16, 2024
Co-authored-by: Rob Walch <robwalch@users.noreply.github.com>
…gajassi/hls.js into feature/attachMedia-null-error
robwalch
requested changes
Jul 17, 2024
robwalch
changed the title
ATTACH_MEDIA_ERROR when calling attachMedia with falsey media argument
robwalch
requested changes
Jul 18, 2024
robwalch
reviewed
Jul 18, 2024
forgot smart quotes
updating test to make it more detailed, and assert error.message
robwalch
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Improves error handling in
hls.attachMedia(media)whennullis passed as a parameter.Why is this Pull Request needed?
Logging error to the console will benefit users when when attachMedia is called with a null parameter and this feedback will also help avoid potential confusion.
Resolves issues:
#6463
Checklist