Fix access of mediaSrc value

[jhonatangcavalcanti]

This PR will...

Fix the access to retrieve the src value from current media.

The problem happens when there is a video element child which is not a source element. Other children could be track or any other element.

Now, instead of retrieving the src from firstChild, it is retrieved from the source element if it exists.

Why is this Pull Request needed?

The cleanup when detaching media is being skipped and an error is wrongly logged due to this problem.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

• changes have been done against master branch, and PR does not conflict
• new unit / functional tests have been added (whenever applicable)
• API or design changes are documented in API.md

[jhonatangcavalcanti]

Hello, @robwalch. Is it possible to add this patch to a new version 1.5.4 on top of 1.5.3?

[robwalch]

Hello, @robwalch. Is it possible to add this patch to a new version 1.5.4 on top of 1.5.3?

Please open a PR against the "patch/v1.5.x" branch.

The latest release is v1.5.13 so that would get merged and released at v1.5.14.

Consider that there may be integrations or platforms where querySelector is not a method available on the object attached (not an actual HTMLMediaElement but an object with a src property).

[jhonatangcavalcanti]

Thanks, @robwalch. I did update this PR pointing to patch/v1.5.x.
I've also added the ac1c666 to keep compatibility with the current implementation of getting the mediaSrc from firstChild.

Is it ok?

[jhonatangcavalcanti]

I'll need to update it again, the new implementation brings back the problem that I've reported.
I'll work on a new commit with a fix

[jhonatangcavalcanti]

I updated and added a check to ensure that media.querySelector is available before executing it.

I don't know if there is a scenario where the media is not a video tag and the firstChild is a valid element with a src attribute.

[robwalch]

@jhonatangcavalcanti,

Thank you for the fix. This has been released in v1.5.14 and merged into dev.