Do not split AVC samples on Access Unit Delimiter without frame data #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
bugfix/avc-nal-aud-samples
branch
from
42e85c1 to
25aedd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Prevent unexpected Access Unit Delimiter (AUD type 9) AVC NAL units from dropping sample data.
Why is this Pull Request needed?
The asset that produced issue #6515 showed artifacts of dropped frames (green and tearing video). The AVC NALs included an AUD unit between each SPS, PPS, and IDR unit. Rather than assume that AUD units are only present between groups of units comprising a frame or complete sample, waiting until a sample with a frame is found before creating the next fixes the issue by not dropping data needed in the remuxed mp4 mdat.
Are there any points in the code the reviewer needs to double check?
Additional Demuxer cleanup to remove unused debug code and prevent leaks after destroying Hls instance.
Resolves issues:
Fixes #6515
Checklist