Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADTS to esds remuxing enhancements #6627

Merged
merged 1 commit into from
Aug 27, 2024
Merged

ADTS to esds remuxing enhancements #6627

merged 1 commit into from
Aug 27, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Aug 9, 2024

This PR will...

Remove user-agent specific and playlist CODEC dependent workarounds from ADTS to mp4 atom "esds" remuxing.

Why is this Pull Request needed?

Various combinations of user-agent and MVP (multivariant playlist/manifest) CODECS values can produce incorrect or unsupported remuxing of AAC audio in M2TS and containerless audio segments.

Are there any points in the code the reviewer needs to double-check?

Resolves issues:

Resolves #6110

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Aug 9, 2024
@robwalch robwalch mentioned this pull request Aug 9, 2024
5 tasks
@robwalch robwalch merged commit 08e8f3b into master Aug 27, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/adts-to-esds branch August 27, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed sound on Pale Moon
1 participant