fix: setMediaKeys return undefined in some browers
#6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
previously approved these changes
Sep 3, 2024
JackPu
force-pushed
the
jackpu/fix_set_media_keys_return_undefined
branch
from
6906d33 to
10cdab7
Compare
|
@robwalch I am going to re-trigger the CI actions via changing commit message. However, it may now need your approval again. |
robwalch
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
We want to add an optional operator to prevent unexpected errors thrown in low-version(<=38) Chrome browser.
You can see the issue here #6663
Even though we support Chrome >= 39. But I think a safety code here is OK. It will not bring some other cost.
Resolves issues:
#6663
Checklist