CMAF KLV support via Metadata callback #6674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leverages the existing metadata callbacks for ID3 tags Not sure this is the best way, but it works for my simple testing
… and exposing of MetadataSchema along with changes to the FRAG_PARSING_METADATA event
robwalch
reviewed
Sep 4, 2024
|
|
Hi, Removing the const cause issues: src/hls.ts:121:12 - error TS2475: 'const' enums can only be used in property or index access expressions or the right hand side of an import declaration or export assignment or type query. I agree it should be a const ideally, but there appeared to be some kind of TS/JS conflict. Code duplication - probably better left as is as you only want to process the PTS etc if you are going to handle the emsg box type Thanks, Glyn |
robwalch
approved these changes
Sep 5, 2024
robwalch
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Optionally extract KLV data that is delivered via CMAF / Mp4 emsg box and return it via Hls.Events.FRAG_PARSING_METADATA events.
This has to be enabled using new config parameter enableEmsgKLVMetadata - defaults to false
This leverages the existing ID3 infra so is a relatively small change, but will deliver all the KLV data for the CMAF segment in one hit - it is then down to the application to display that data at the appropriate time.
Why is this Pull Request needed?
To allow users to display KLV timed data aligned with video
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist