Add loaders and other modules used in config to ESM output #6733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroller, requestMediaKeySystemAccess in ESM output (hls.mjs) Fix: Disable progressive callbacks in fLoader when progressive mode is disabled Resolves #6707
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
Allows config options
fLoader,pLoader, andloaderto be set to imported Loader class, or a custom loader sub-class.Are there any points in the code the reviewer needs to double check?
Fixes a bug with setting
fLoadertoFetchLoaderwith defaultprogressive: false: data was empty on complete and onProgress was a no-op. Now onProgress no-op is not passed in to fLoader when not in progressive mode so that the correct more direct path is taken to returning data on complete.Resolves issues:
Resolves #6707
Checklist