Check-in on abandon rules check and abort in-flight frag when stuck on playlist loading #6763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-flight frag Resolves #6689
robwalch
force-pushed
the
bugfix/issue-6689
branch
from
e629ade to
23d096e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Check-in on abandon rules check and abort in-flight frag when stuck on playlist loading
Why is this Pull Request needed?
Switches down to a variant that should load at line speed when the higher bitrate in-flight fragment is late. If the playlist of the lower variant still hasn't arrived by the time estimated, and the original in-flight fragment is still active, abort it and switch down further if needed.
Are there any points in the code the reviewer needs to double check?
Fixes redundant switching level / level loading events that occur for VOD when playlist loading is significantly delays. These events cancel the fallback abandon rules check playlist timeout.
Resolves issues:
Resolves #6689 (provided throttled requests do not timeout)
Checklist