Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null XHR response handling #6842

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

robwalch
Copy link
Collaborator

This PR will...

Fix null XHR response handling

Why is this Pull Request needed?

Prevents an Invalid State exception thrown by reading xhr.responseText when xhr.response is null and xhr.responseType is not "text" or empty.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…hen xhr.response is null and responseType is not text or empty
@robwalch robwalch added this to the 1.6.0 milestone Nov 14, 2024
@robwalch robwalch merged commit 8593c31 into master Nov 14, 2024
15 of 16 checks passed
@robwalch robwalch deleted the bugfix/xhr-response-text-invalid-state branch November 14, 2024 21:47
@robwalch robwalch modified the milestones: 1.6.0, 1.5.18 Dec 17, 2024
robwalch added a commit that referenced this pull request Dec 17, 2024
* Prevent Inivalid State exception thrown by reading xhr.responseText when xhr.response is null and responseType is not text or empty

(cherry picked from commit 8593c31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant