Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-align audio playlist with main when there is no overlap between audio playlist updates #6857

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Nov 21, 2024

This PR will...

  • Attempt to realign audio with main when alignPlaylists finds no overlap in live playlist updates.
  • Wait for audio rendition playlist update when ending discontinuity is not matched in main playlist.
  • startCC of LevelDetails will be set to DISCONTINUITY-SEQUENCE when playlists begin with a DISCONTINUITY tag instead of the sequence number of the first fragment (starting sequence +1), allowing alignment on first segment with new discontinuity.
  • Prevent audio-stream-controller state changes to "WAITING..." when loading is stopped.

Why is this Pull Request needed?

  • Realigns live main and audio playlists after media sequence sync is lost.
  • Prioritizes discontinuity sequence alignment over program date time.
  • Prevents audio segment fetching of new discontinuity until main discontinuity sequence is avaiable.

Are there any points in the code the reviewer needs to double check?

Audio playlists aligned with main on program date time at start can have negative start times.

Resolves issues:

Resolves #6823

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Nov 21, 2024
@robwalch robwalch mentioned this pull request Nov 21, 2024
5 tasks
Base automatically changed from bugfix/live-resume-wait-for-refresh to master November 21, 2024 19:45
@robwalch robwalch force-pushed the bugfix/live-audio-realign branch from 50c9957 to feac307 Compare November 21, 2024 20:28
@robwalch robwalch merged commit ac4be62 into master Nov 22, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/live-audio-realign branch November 22, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

av desync on server restart
1 participant