Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interstitial transfer of media (element) while primary is re-attaching #6903

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Dec 10, 2024

This PR will...

Fix interstitial transfer of media while primary is re-attaching.

Why is this Pull Request needed?

Allows scrubbing along interstitial timeline without media element being emptied while re-attaching to another player.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Dec 10, 2024
@robwalch robwalch force-pushed the bugfix/interstitial-transitions-attaching branch from 795507b to d57baea Compare December 10, 2024 22:14
@robwalch robwalch force-pushed the bugfix/interstitial-transitions-attaching branch from d57baea to b5a2b86 Compare December 10, 2024 22:15
@robwalch robwalch merged commit d7090f0 into master Dec 10, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/interstitial-transitions-attaching branch December 10, 2024 22:42
@robwalch robwalch changed the title Fix interstitial transfer of media while primary is re-attaching Fix interstitial transfer of media (element) while primary is re-attaching Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant