fix(vg-scrub-bar): Scrub bar was glitching on mobile #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to my issue #101, the scrub bar was unreliable on iOS when lifting your finger. I fixed the scrub bar in probably the most low effort solution I could come up with. I tested it on iOS Chrome, iOS Safari, and Windows Chrome.
I fixed it by: Removed the scrub bar changes from happening on touchend event.
Since there are events for touchstart and touchmove, having a touchend event that also makes changes to the scrub bar percent is not needed.
Checklist
Please, check that you have been followed next steps:
npm start
)npm test
)Note: I didn't run
npm run commit
. Also I had to remove a test, however this is just a simple result of the changes made and not an error.