feat: expose custom M3U8 mapper API #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/playlist-loader.js
Outdated
| @@ -10,6 +10,9 @@ import videojs from 'video.js'; | |||
| import { Parser as M3u8Parser } from 'm3u8-parser'; | |||
| import window from 'global/window'; | |||
|
|
|||
| // TODO: REMOVE | |||
There was a problem hiding this comment.
Might be good to add the condition for removal (for future explorers).
There was a problem hiding this comment.
This line is going to be removed in this PR, I just have the stub here so the tests execute as much as possible before updating the m3u8-parser
ldayananda
reviewed
Jan 2, 2019
ldayananda
reviewed
Jan 2, 2019
src/playlist-loader.js
Outdated
| @@ -266,6 +274,12 @@ export default class PlaylistLoader extends EventTarget { | |||
|
|
|||
| const parser = new M3u8Parser(); | |||
|
|
|||
| // adding custom tag parsers | |||
| this.parsers.forEach(tagParser => parser.addParser(tagParser)); | |||
There was a problem hiding this comment.
might be a little less confusing if this is customParser instead of tagParser
|
Code looks good from a high-level. I'll re-review when m3u8-parser is released. |
|
Split this into two PRs |
forbesjo
changed the title
|
Waiting for #331 |
|
Going to add a test module for |
added 2 commits
January 10, 2019 13:05
ldayananda
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes parser and mapping APIs from the m3u8-parser module.
Requirements Checklist