Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for #EXT-X-I-FRAMES-ONLY #173

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Jul 25, 2023

Description

Handles I-frames-only segments, providing a basis for the creation of trick-play functionality.

Specific Changes proposed

parse-stream.js

  • add match statement for parsing the EXT-X-I-FRAMES-ONLY tag
  • add test case

parser.js

  • add a property iFramesOnly to the manifest
  • add a function to validate the minimum version required
  • trigger a warn event if the minimum version required is not supported or undefined, as required by the specification
  • add test case

https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.3.6

  • update README.md documentation

Handles I-frames-only `segments`, providing a basis for the creation of trick-play functionality.

**parse-stream.js**

- add match statement for parsing the `EXT-X-I-FRAMES-ONLY` tag
- add test case

**parser.js**

- add a property `iFramesOnly` to the `manifest`
- add a function to validate the minimum version required
- trigger a `warn` event if the minimum version required is not supported or undefined, as required by the specification
- add test case

https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.3.6

- update `README.md` documentation
Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

src/parse-stream.js Outdated Show resolved Hide resolved
@mister-ben mister-ben merged commit e5dbdb6 into videojs:main Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants