Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exception on #EXT-X-MEDIA-TIME tag #22 #45

Closed
wants to merge 1 commit into from
Closed

Fix Exception on #EXT-X-MEDIA-TIME tag #22 #45

wants to merge 1 commit into from

Conversation

ost12666
Copy link

@ost12666 ost12666 commented Apr 27, 2018

#22

@forbesjo
Copy link
Contributor

forbesjo commented Aug 3, 2018

Hi thank your for your PR! Could you make an additional update to make : required for the other tags as well? I could see other custom tags getting in a similar situation.

Additionally, adding a null/empty string check to parseAttributes (https://github.com/videojs/m3u8-parser/blob/master/src/parse-stream.js#L26) would be helpful.

@ost12666
Copy link
Author

ost12666 commented Aug 6, 2018

Done in a new PR #50 closing this one

@ost12666 ost12666 closed this Aug 6, 2018
@ost12666
Copy link
Author

ost12666 commented Aug 6, 2018

@forbesjo I tried to do a new PR but it failed because one of the parser dependencies uses 'let' and the parser node 4 tests fail. Not sure what to do now...

/home/travis/build/videojs/m3u8-parser/node_modules/videojs-standard/filterer.js:11
let key;
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants