Chore/use vhs utils #295
Chore/use vhs utils #295
Conversation
There was a problem hiding this comment.
Given that we already import the cjs file currently but in the other projects we import the esm file, maybe we can skipt this change in mux until we modernize it? Stream.js won't be deduped anyway and we can keep this project depdendency free for a little while longer.
|
|
||
| var MuxStream = function() {}; | ||
|
|
||
| MuxStream.prototype = new Stream(); |
There was a problem hiding this comment.
Object.create(Stream.prototype) would be preferable.
There was a problem hiding this comment.
Potentially, setting the constructor prop could be done in the same call to Object.create, but we'd want to double check that won't be an issue on IE11: https://github.com/kaelzhang/node-util-inherits/blob/master/index.js#L10-L17
| @@ -78,5 +78,8 @@ | |||
| "uglify-js": "^2.6.2", | |||
| "watchify": "^3.6.1", | |||
| "webworkify": "^1.0.2" | |||
| }, | |||
| "dependencies": { | |||
| "@videojs/vhs-utils": "github:videojs/vhs-utils#force-dist" | |||
There was a problem hiding this comment.
The first dependency. It was nice that this lib didn't have any previously.
|
yeah maybe we can skip this one for now, until we modernize it |
|
Cool, let's close it for now. |
No description provided.