Skip to content

Commit

Permalink
feat: global hotkey support
Browse files Browse the repository at this point in the history
  • Loading branch information
sinaru committed Nov 2, 2024
1 parent ecef37c commit 461bab0
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions src/js/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,8 @@ class Player extends Component {

this.boundUpdatePlayerHeightOnAudioOnlyMode_ = (e) => this.updatePlayerHeightOnAudioOnlyMode_(e);

this.boundGlobalKeydown_ = (e) => this.handleGlobalKeydown_(e);

// default isFullscreen_ to false
this.isFullscreen_ = false;

Expand Down Expand Up @@ -611,6 +613,10 @@ class Player extends Component {
this.on('keydown', (e) => this.handleKeyDown(e));
this.on('languagechange', (e) => this.handleLanguagechange(e));

if (this.isGlobalHotKeysEnabled()) {
Events.on(document.body, 'keydown', this.boundGlobalKeydown_);

Check warning on line 617 in src/js/player.js

View check run for this annotation

Codecov / codecov/patch

src/js/player.js#L617

Added line #L617 was not covered by tests
}

this.breakpoints(this.options_.breakpoints);
this.responsive(this.options_.responsive);

Expand Down Expand Up @@ -646,6 +652,7 @@ class Player extends Component {
// Make sure all player-specific document listeners are unbound. This is
Events.off(document, this.fsApi_.fullscreenchange, this.boundDocumentFullscreenChange_);
Events.off(document, 'keydown', this.boundFullWindowOnEscKey_);
Events.off(document.body, 'keydown', this.boundGlobalKeydown_);

if (this.styleEl_ && this.styleEl_.parentNode) {
this.styleEl_.parentNode.removeChild(this.styleEl_);
Expand Down Expand Up @@ -2247,6 +2254,12 @@ class Player extends Component {
this.trigger('textdata', data);
}

handleGlobalKeydown_(event) {
if (event.target === document.body) {
this.handleKeyDown(event);

Check warning on line 2259 in src/js/player.js

View check run for this annotation

Codecov / codecov/patch

src/js/player.js#L2257-L2259

Added lines #L2257 - L2259 were not covered by tests
}
}

/**
* Get object for cached values.
*
Expand Down Expand Up @@ -4570,6 +4583,10 @@ class Player extends Component {
this.height(this.audioOnlyCache_.controlBarHeight);
}

isGlobalHotKeysEnabled() {
return !!(this.options_ && this.options_.userActions && this.options_.userActions.globalHotkeys);
}

enableAudioOnlyUI_() {
// Update styling immediately to show the control bar so we can get its height
this.addClass('vjs-audio-only-mode');
Expand Down

0 comments on commit 461bab0

Please sign in to comment.