Skip to content

Commit

Permalink
fix: remove 'use strict' from rollup because vttjs isn't strict (#4551)
Browse files Browse the repository at this point in the history
  • Loading branch information
gkatsev authored Aug 14, 2017
1 parent 6233d14 commit db55bbd
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions build/rollup.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ const es = {
legacy: true
},
banner: compiledLicense(Object.assign({includesVtt: true}, bannerData)),
useStrict: false,
format: 'es',
dest: 'dist/video.es.js'
};
Expand All @@ -94,6 +95,7 @@ const umd = {
legacy: true
},
banner: compiledLicense(Object.assign({includesVtt: true}, bannerData)),
useStrict: false,
format: 'umd',
dest: 'dist/video.js'
};
Expand Down Expand Up @@ -134,10 +136,11 @@ const minifiedNovttUmd = Object.assign({}, _.cloneDeep(minifiedUmd), {

minifiedNovttUmd.options.plugins.unshift(ignore(['videojs-vtt.js']));

function runRollup({options, format, dest, banner}) {
function runRollup({options, useStrict, format, dest, banner}) {
rollup(options)
.then(function(bundle) {
bundle.write({
useStrict,
format,
dest,
banner,
Expand All @@ -161,7 +164,7 @@ if (!args.watch) {
runRollup(novttUmd);
}
} else {
const props = ['format', 'dest', 'banner'];
const props = ['format', 'dest', 'banner', 'useStrict'];
const watchers = [
['es', watch({rollup},
Object.assign({},
Expand Down

0 comments on commit db55bbd

Please sign in to comment.