Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The aria-valuetext for the volume control slider contains two decimal places on a 0 to 100% scale! #4022

Closed
OwenEdwards opened this issue Feb 2, 2017 · 0 comments · Fixed by #4023
Closed

The aria-valuetext for the volume control slider contains two decimal places on a 0 to 100% scale! #4022

OwenEdwards opened this issue Feb 2, 2017 · 0 comments · Fixed by #4023
Assignees
@brandonocasey
Labels
a11y This item might affect the accessibility of the player

Comments

@OwenEdwards
Copy link
Member

Description

Screen reader announces volume as, e.g. "eight-point-zero-zero-percent". Since a keyboard-only user can only move the volume control in steps of 10, the two decimal places of precision in aria-valuetext are completely unnecessary!

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Use a screen reader, such as VoiceOver on macOS, to read out the value of the volume control slider!

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

v6.0.0-RC.1

browsers

All

OSes

All

plugins

none
@OwenEdwards OwenEdwards added the a11y This item might affect the accessibility of the player label Feb 2, 2017
@brandonocasey brandonocasey mentioned this issue Feb 2, 2017
Merged
4 tasks
brandonocasey added a commit that referenced this issue Feb 2, 2017
@brandonocasey
fix: accessibility bugs with the VolumeBar
3a317fa 
* Fixes #4021: drop the decimal places on aria-valuenow and aria-valuetext
* Fixes #4022: aria-valuenow and aria-valuetext not set initially
brandonocasey added a commit that referenced this issue Feb 2, 2017
@brandonocasey
fix: accessibility bugs with the VolumeBar (#4023)
da2a1e0 
* Fixes #4021: drop the decimal places on aria-valuenow and aria-valuetext
* Fixes #4022: aria-valuenow and aria-valuetext not set initially
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandonocasey brandonocasey

Labels
a11y This item might affect the accessibility of the player
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: accessibility bugs with the VolumeBar videojs/video.js
2 participants
@OwenEdwards @brandonocasey