-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default flag not working on tracks (subtitles, captions) #656
Comments
It looks like there's a partial implementation that could be un-commented. Needs to be tested. |
A fix of that bug (or a public function to enable the track via js) would be greatly appreciated! Thanks! |
+1 |
I solved this problem by modifying method vjs.TextTrackMenuItem (line: 6666):
|
@Korotkiewicz thanks a lot it worked for me... |
Thanks @Korotkiewicz, for tracking this down and posting a workable solution to the issue. However, I did not see a pull request for the fix, so I took a second look and found that it was failing one of the unit tests. I tracked this down to the player.js test where it checks the validity of the player and associated tracks. I believe the test failed because (with the newly added fix) there is no external file to pull the content from on default, hence the failure. Adding an additional check to see if the video was set to auto preload is one possible solution.
|
…n tracks (subtitles, captions)" Added additional check to look for auto preload option to avoid loading external captions, subtitles, etc. file on default
…orking on tracks (subtitles, captions)"" This reverts commit 8735935.
The default subtitles are not showing when the video is played. However, it works correctly when choosing it form the menu.
Here's my code:
Is it a bug or I am doing something wrong?
Upon Googling the issue I found some people are facing the same issue.
Please help.
The text was updated successfully, but these errors were encountered: