Making sure that the title element gets placed into the UL element #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks! |
| }); | ||
|
|
||
| var menuContentElement = menuButton.el().getElementsByTagName('UL')[0]; | ||
| var titleElement = menuContentElement.getElementsByClassName( |
There was a problem hiding this comment.
I think we'll need to use something other than getElementsByClassName to get tests to pass in IE8.
There was a problem hiding this comment.
i can probably iterate over the children, the first one should be the one we want
Included are two sanity check tests for the two areas being checked to make sure that the menu title items are being correctly placed in the actual UL element of the menu. Fixes videojs#1107
|
@heff updated to use the |
| @@ -129,7 +129,7 @@ vjs.MenuButton.prototype.createMenu = function(){ | |||
|
|
|||
| // Add a title list item to the top | |||
| if (this.options().title) { | |||
| menu.el().appendChild(vjs.createEl('li', { | |||
| menu.contentEl().appendChild(vjs.createEl('li', { | |||
| className: 'vjs-menu-title', | |||
| innerHTML: vjs.capitalize(this.kind_), | |||
There was a problem hiding this comment.
I found some other related issues after pulling this in. For instance, this.kind_ here should really be this.options().title. Kind must have gotten copied over from tracks at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included are two sanity check tests for the two areas being checked
to make sure that the menu title items are being correctly placed
in the actual UL element of the menu.
Fixes #1107