Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #673 #1155

Closed
wants to merge 2 commits into from
Closed

Fixes issue #673 #1155

wants to merge 2 commits into from

Conversation

mattvaughan
Copy link

Most credit to @jewel for code. Mine differs only in the order of else's so that the minified version works.

…it to github user @jewel for the code changes. I just rearranged to fix minified generation, though this is another issue to look into.
@heff
Copy link
Member

heff commented Apr 18, 2014

Thanks! I need to combine this with #1101, and then test it out.

Pulling in changes to work on the latest code.
@TrevorRawlings
Copy link

I'm loving videojs and full screen support for IE11 is an excellent addition but it looks like using msFullscreenElement results in a small difference in behaviour within vjs.Player.prototype.requestFullScreen().

Since msFullscreenElement returns a DOM element the vjs.on(document, 'MSFullscreenChange', ...) event listener doesn't get removed when exiting full screen.

I'm not familiar with the code so there's probably a more elegant solution but for me adding a !! worked around the problem:

if (!!this.isFullScreen() === false) {
vjs.off(document, requestFullScreen.eventName, arguments.callee);
}

@heff
Copy link
Member

heff commented May 14, 2014

I built on top of this for #1205. If you can, check out the branch and see if it works for you.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants