Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower: ignore dot files, build and tests #1337

Merged
merged 1 commit into from
Jul 28, 2014
Merged

bower: ignore dot files, build and tests #1337

merged 1 commit into from
Jul 28, 2014

Conversation

gkralik
Copy link

@gkralik gkralik commented Jul 9, 2014

Add 'ignore' directive to bower.json.

This ignores all dot files, test directories and build directories. Fixes #1105.

@heff
Copy link
Member

heff commented Jul 9, 2014

#1337, it must be good. :) Thanks for this.

"node_modules",
"bower_components",
"test",
"tests",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have tests, node_modules, or bower_components directories in the repo. Are they needed, and if not, can you remove them?

@gkralik
Copy link
Author

gkralik commented Jul 9, 2014

These are just the standard ignored directories for bower packages. I could exclude them if you want, but I don't think they hurt...

@heff
Copy link
Member

heff commented Jul 9, 2014

If that’s the case that should be fine, but could you comment here with link to a guide or example of that so we have a record of it?

@gkralik
Copy link
Author

gkralik commented Jul 9, 2014

I'll look up the reference tomorrow morning. They're the paths that are recommended when running bower init.

@gkralik
Copy link
Author

gkralik commented Jul 9, 2014

Just found this in bower source code:https://github.com/bower/bower/blob/v1.3.1/lib/commands/init.js#L289-L296

@heff
Copy link
Member

heff commented Jul 9, 2014

perfect, thanks!

@heff heff merged commit bdc89a0 into videojs:master Jul 28, 2014
heff added a commit that referenced this pull request Jul 28, 2014
@heff
Copy link
Member

heff commented Jul 28, 2014

Thank you!

If you're on IRC join the #videojs room to chat with other contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dist from gitignore in distribution branch?
2 participants