Make sure the error property is set before proxying through the tech. #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some error events don't cause the error property on the video element to be set. In that case, handle the event like any other. Fixes videojs#1465.
|
Nice. Seems like a good way to fix this. |
heff
added a commit
that referenced
this pull request
Sep 5, 2014
|
Merged into stable. I've been cherry-picking these so not sure github will handle closing them. It might after they're merged into master. |
|
@heff probably not. Next time, I wonder if opening the PRs up against stable would help and then merging stable into master? |
|
Yeah, hotfixes against stable would simplify this. Though it looks like it may have worked in #1481? |
|
This has been merged and released in 4.8.1 |
|
@heff I think because that commit had the "fixes ####" directive in it. |
|
ah, right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some error events don't cause the error property on the video element to be set. In that case, handle the event like any other. Fixes #1465.