Added the ability to set options for child components directly on the parent options

[heff]

For example if you wanted to disable the mute toggle:

videojs(id, { controlBar: { muteToggle: false } });

Whereas before you had to do:

videojs(id, { children: { controlBar: { children: { muteToggle: false } } } });

@mmcc, ping

[gkatsev]

Finally!

[mmcc]

Wow this is only a few lines more than when we were talking about the other day...looks great to me.

[heff]

Ha, whatever Gary, "finally" :-P

Yeah it wasn't too crazy of a change.

I should have noted that this allows us to define children with an array, while still having the option to easily disable specific children later.

options = {
  children: ['myComponent', 'myOtherComponent'],
  myComponent: false
}

We couldn't do that before with the array method, but the array is safer for specific child ordering. I'm not sure how significant of a change it would be, but we should start moving over to using arrays for all components.

[heff]

Merged this in, though it'd probably be good to look for any areas we can improve docs on this, if there are any

[mmcc]

I mention this in that doc branch, so I’ll make this change before resubmitting.

—
Matthew McClure

On Tue, Oct 28, 2014 at 11:46 AM, Steve Heffernan
notifications@github.com wrote:

Merged this in, though it'd probably be good to look for any areas we can improve docs on this, if there are any

Reply to this email directly or view it on GitHub:
#1599 (comment)