Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vjs-scrubbing class to player while scrubbing #1741

Closed
wants to merge 2 commits into from

Conversation

jcaron23
Copy link
Contributor

This is useful to add CSS preventing hover menus from opening while scrubbing, even if the mouse strays out of the seek bar.

@mmcc
Copy link
Member

mmcc commented Dec 13, 2014

Thank you! Are you just doing this so you can add .vjs-scrubbing styles in your app or did you have default classes in mind?

@heff
Copy link
Member

heff commented Dec 16, 2014

@jcaron23 just following up on this. When I test scrubbing on videojs.com and roll over the captions menu, the menu doesn't show. Is there a live example of this happening, or could we create a jsbin for it?

@jcaron23
Copy link
Contributor Author

Which browser did you test it on? Safari appears to block :hover while the mouse is down, but Firefox and IE don't. Haven't checked Chrome.

@heff
Copy link
Member

heff commented Dec 16, 2014

Yeah, no issues on Safari or Chrome but I was able to reproduce it on Firefox. Thanks for pointing that out. Would you want to help update the existing menus to use the vis-scrubbing class?

@jcaron23
Copy link
Contributor Author

I currently use this CSS:
/* prevent menus from opening while scrubbing (FF, IE) */
.vjs-default-skin.vjs-scrubbing .vjs-menu-button:hover .vjs-menu {
display: none;
}

Not quite sure it necessarily fits in the general case.

Also, it might be better to actually have some sort of not-scrubbing class (so we can just have the :hover work only on not-scrubbing, but that probably requires quite a few more changes.

@heff
Copy link
Member

heff commented Dec 16, 2014

Nice, I think the first option looks good to me. Want to add it to the pull request?

@jcaron23
Copy link
Contributor Author

Added (slightly edited) CSS rule to video-js.less

heff added a commit that referenced this pull request Dec 22, 2014
@heff
Copy link
Member

heff commented Dec 22, 2014

This has been merged into master and will go out with the next release. Thanks Jacques!

@heff heff closed this Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants