ManualTimeUpdatesOff was not de-registering events #1793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManualTimeUpdatesOff was trying to de-register trackCurrentTime and stopTrackingCurrentTime against itself rather than the player, which is where these events were registered against.
|
lgtm |
|
@mmcc, want to attempt merging this in with contrib? |
|
yep |
mmcc
pushed a commit
to mmcc/video.js
that referenced
this pull request
Jan 16, 2015
…ring events. closes videojs#1793
mmcc
pushed a commit
to mmcc/video.js
that referenced
this pull request
Jan 16, 2015
…ring events.. closes videojs#1793
|
^^ thanks, auth. |
mmcc
referenced
this pull request
Jan 20, 2015
|
this same issue exists for 'controlsenabled' and 'controlsdisabled' event. we never have a deregister for these events. so if we load another tech as part of src(value) and then dispose, we are getting exception. we should deregister these events as well. |
|
@giakas yes we should. Would you be up for submitting a PR for that change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManualTimeUpdatesOffwas trying to de-registertrackCurrentTimeandstopTrackingCurrentTimeagainst itself rather than the player, which iswhere these events were registered against.
This manifests itself if you have flash-based tech that is loaded initially and then try to unload it and switch to an html5-based tech.