Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix woff font. Closes #1775 #1796

Closed
wants to merge 1 commit into from
Closed

Fix woff font. Closes #1775 #1796

wants to merge 1 commit into from

Conversation

mister-ben
Copy link
Contributor

Re-exported woff font to avoid bad linegap error on Firefox.

@heff
Copy link
Member

heff commented Jan 16, 2015

I was able to confirm the error and that this PR fixes it. It's not great that it affects the icon size, but not sure what we're supposed to do to fix this otherwise. @mmcc, should we just merge this in or try to fix the icon size?

@mmcc
Copy link
Member

mmcc commented Jan 21, 2015

I think we should try to fix the icon size if we're going to merge this in, it would stink to break things for folks right before we push an entirely new version of the font / theme.

@heff
Copy link
Member

heff commented Jan 22, 2015

@mmcc is going to try exporting again and see if that fixes the size issue. If not we'll just merge this in.

@gkatsev
Copy link
Member

gkatsev commented Jan 22, 2015

We shouldn't merge this in if it's going to break things.

@heff
Copy link
Member

heff commented Feb 13, 2015

@mister-ben, could we get a screen shot on how different the icons look with the fix? I don't think we're going to be able to pull this in until we figure out how to get the icons back to normal.

@mister-ben
Copy link
Contributor Author

before http://jsbin.com/axedog/

after http://jsbin.com/koticu/

However I think I've been able to fix it in a better way now by editing the metrics in FontForge. I'll do some more testing with that and update.

@mister-ben
Copy link
Contributor Author

Closing this in favour of #1870

@mister-ben mister-ben closed this Feb 17, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants