Added vjs-button class to button controls #2084
Conversation
| @@ -1,4 +1,5 @@ | |||
| .video-js .vjs-control { | |||
| .video-js .vjs-control, | |||
| .video-js .vjs-button { | |||
There was a problem hiding this comment.
Actually, we can remove all of these vjs-button additions in the CSS. All of the elements already have the vjs-control class name, so all of those styles will already apply.
There was a problem hiding this comment.
I'll remove them, I initially added them in case we remove vjs-control from
the buttons in the future.
On Tue, Apr 28, 2015 at 6:07 PM Steve Heffernan notifications@github.com
wrote:
In src/css/components/_control.scss
#2084 (comment):@@ -1,4 +1,5 @@
-.video-js .vjs-control {
+.video-js .vjs-control,
+.video-js .vjs-button {Actually, we can remove all of these vjs-button additions in the CSS. All
of the elements already have the vjs-control class name, so all of those
styles will already apply.—
Reply to this email directly or view it on GitHub
https://github.com/videojs/video.js/pull/2084/files#r29293744.
There was a problem hiding this comment.
Cool, got it. That makes sense but we should do that in the same PR where we adjust the buttons.
|
Made one comment but otherwise it looks good to me. The test failed for an unrelated reason so restarted them. |
|
Very nice. Lgtm! |
Fixe for issue #1204